Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in grid documentation #13662

Closed
sshevlyagin opened this issue Nov 21, 2018 · 5 comments
Closed

Typo in grid documentation #13662

sshevlyagin opened this issue Nov 21, 2018 · 5 comments
Labels
docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@sshevlyagin
Copy link
Contributor

Expected Behavior 🤔

The documentation should say:
Adding a padding on the parent with, at least, half the spacing value:

Current Behavior 😯

The documentation says:
Adding a padding on the parent with, at least, the spacing value:

Steps to Reproduce 🕹

  1. Navigate to grid doc
@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process. labels Nov 21, 2018
@oliviertassinari
Copy link
Member

@sshevlyagin You are 💯 correct, thank you for the precision. Do you want to submit a pull request to update that? You can find the source here: https://github.com/mui-org/material-ui/blob/master/docs/src/pages/layout/grid/grid.md#negative-margin.

@joshwooding
Copy link
Member

joshwooding commented Nov 21, 2018

Building on this maybe it should read either:
Adding padding to the parent with, at least, half the spacing value:
Adding a padding property to the parent with, at least, half the spacing value:
Adding the padding style property to the parent with, at least, half the spacing value:

@oliviertassinari
Copy link
Member

cc @mbrookes 💡

@mbrookes
Copy link
Member

mbrookes commented Nov 21, 2018

How about:

“Applying padding to the parent with at least half the the spacing value applied to the child:”

Also:

“Applying overflow-x: hidden; to the parent.”

@sshevlyagin
Copy link
Contributor Author

Sounds good @mbrookes, PR created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process.
Projects
None yet
Development

No branches or pull requests

4 participants