Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typescript] Button type attribute typing needs to be updated #15076

Closed
karlbohlmark opened this issue Mar 27, 2019 · 3 comments
Closed

[Typescript] Button type attribute typing needs to be updated #15076

karlbohlmark opened this issue Mar 27, 2019 · 3 comments
Labels
bug 🐛 Something doesn't work typescript

Comments

@karlbohlmark
Copy link
Contributor

The typings for the type attribute on Button no longer matches the typing in @types/react since commit: DefinitelyTyped/DefinitelyTyped@4d371be

@oliviertassinari
Copy link
Member

The problem surfaced because of a change in @types/react: DefinitelyTyped/DefinitelyTyped#34194. To prevent the issue either pin @types/react to a previous version or use a fork of Button.d.ts with paths alias.

@oliviertassinari
Copy link
Member

Released as v3.9.3.

@mcmillhj-wta
Copy link

mcmillhj-wta commented Oct 21, 2019

@oliviertassinari Is there an example somewhere of how to properly override with the paths option from tsconfig.json?

Currently doing this:

"paths": {
    "@material-ui/core/*": ["typings/@material-ui/core/*"]
 }

...

src/typings
└── @material-ui
    └── core
        └── Button
            ├── Button.d.ts
            ├── Button.js
            ├── index.d.ts
            └── index.js

but have a feeling I have done something wrong.

We are on a very old version of @material-ui/core, otherwise I would just upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work typescript
Projects
None yet
Development

No branches or pull requests

3 participants