Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Button] Fix typing for type-attribute #15077

Merged
merged 1 commit into from
Mar 28, 2019
Merged

[Button] Fix typing for type-attribute #15077

merged 1 commit into from
Mar 28, 2019

Conversation

karlbohlmark
Copy link
Contributor

@karlbohlmark karlbohlmark commented Mar 27, 2019 •
edited by oliviertassinari
Loading

Narrow typing for the type attribute in Button and Fab to be compatible with latest typings for react.

Closes #15076

@karlbohlmark karlbohlmark mentioned this pull request Mar 27, 2019
Closed
1 task
@eps1lon eps1lon self-assigned this Mar 27, 2019
@mui-pr-bot
Copy link

No bundle size changes comparing be889d9...2e0ba6b

Generated by 🚫 dangerJS against 2e0ba6b

@eps1lon eps1lon added bug 🐛 Something doesn't work component: button This is the name of the generic UI component, not the React module! typescript component: Fab The React component. labels Mar 27, 2019
@GitJacek

This comment has been minimized.

Sign in to view
@skibickipawel

This comment has been minimized.

Sign in to view
@fosfuan

This comment has been minimized.

Sign in to view
@podolskip

This comment has been minimized.

Sign in to view
@eps1lon eps1lon merged commit f036b5c into mui:next Mar 28, 2019
@eps1lon
Copy link
Member

eps1lon commented Mar 28, 2019

@karlbohlmark Thanks.

At the rest that felt like spamming this PR helps: Releases are usually every 1-2 weeks, PRs rarely get merged without double checking.

The problem surfaced because of a change in @types/react. To prevent the issue either pin @types/react to a previous version or use a fork of Button.d.ts with paths alias.

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 28, 2019 •
edited
Loading

It will be released this weekend under v4.0.0-alpha.6.

@snurby7 snurby7 mentioned this pull request Mar 28, 2019
Closed
@oliviertassinari
Copy link
Member

I think that we should backport this change to master and to a quick release. Anyone?

@oliviertassinari oliviertassinari removed the component: Fab The React component. label Mar 28, 2019
@GitJacek
Copy link

@karlbohlmark Thanks.

At the rest that felt like spamming this PR helps: Releases are usually every 1-2 weeks, PRs rarely get merged without double checking.

The problem surfaced because of a change in @types/react. To prevent the issue either pin @types/react to a previous version or use a fork of Button.d.ts with paths alias.

The problem is that '@types/react-dom' has '@types/react' as dependency, it install latest version, so when i downgrade '@types/react' I can't build my project anyway, because i get:
error TS2300: Duplicate identifier 'LibraryManagedAttributes'

oliviertassinari pushed a commit to oliviertassinari/material-ui that referenced this pull request Mar 28, 2019
@karlbohlmark @oliviertassinari
[Button] Narrow type for type prop (mui#15077)
73074be
@oliviertassinari oliviertassinari mentioned this pull request Mar 28, 2019
Merged
oliviertassinari pushed a commit to oliviertassinari/material-ui that referenced this pull request Mar 28, 2019
@karlbohlmark @oliviertassinari
[Button] Narrow type for type prop (mui#15077)
fe1da3b
@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 28, 2019 •
edited
Loading

I will cut a v3 release once #15096 is merged.

oliviertassinari added a commit that referenced this pull request Mar 28, 2019
@oliviertassinari
[Button] Narrow type for type prop (#15077) (#15096)
d45067d
@oliviertassinari
Copy link
Member

Released as v3.9.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunosallum brunosallum brunosallum approved these changes

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon eps1lon approved these changes

Assignees

@eps1lon eps1lon

Labels
bug 🐛 Something doesn't work component: button This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@karlbohlmark @mui-pr-bot @GitJacek @skibickipawel @fosfuan @podolskip @eps1lon @oliviertassinari @brunosallum