Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alternateTextColor should not be used for background #1760

Closed
quanglam2807 opened this issue Sep 29, 2015 · 1 comment
Closed

alternateTextColor should not be used for background #1760

quanglam2807 opened this issue Sep 29, 2015 · 1 comment
Labels
customization: theme Centered around the theming features

Comments

@quanglam2807
Copy link
Contributor

I tried to customize darkTheme to change the text and icon of AppBar, Button, etc from black to white. But if I change alternateTextColor, it will also affect the background of Paper, LeftNav, etc. I think we should have 2 different variables in this case as the text of AppBar or Button can be black or white (according to Google Design guidelines).
@shaurya947
Copy link
Contributor

@quanglam2807 I think I agree.

The key in the raw theme was originally called canvasColor but when I realized it was being used for text in a lot of places, I decided to rename it to alternateTextColor and to use that instead.

Yes we should have 2 different variables: alternateTextColor and canvasColor, and you could make sure that wherever background color is used, it goes to canvasColor. Would you like to submit a PR for this? You would have to change:

  • light-raw-theme and dark-raw-theme files
  • theme-manager to use the new variables
  • the documentation

@quanglam2807 quanglam2807 mentioned this issue Sep 29, 2015
Merged
mnajdova pushed a commit to mnajdova/material-ui that referenced this issue Nov 10, 2020
@dmtrKovalenko
Improve renderInput spreading experience (mui#1760)
7d6525b 
* Improve input customization exprience and add new examples

* Remove data-mui-test from renderInput props

* Fix Cypress tests and ts error
@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 25, 2022
@zannager zannager added customization: theme Centered around the theming features and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 13, 2023
@chrishoage chrishoage mentioned this issue Sep 2, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
customization: theme Centered around the theming features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

provide more accurate types for useTextField chrishoage/react-spectrum
4 participants
@quanglam2807 @oliviertassinari @shaurya947 @zannager