Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[example] Gatsby sandbox link doesn't work out-of-the-box #26332

Closed
2 tasks done
SandersAaronD opened this issue May 17, 2021 · 3 comments · Fixed by #27798
Closed
2 tasks done

[example] Gatsby sandbox link doesn't work out-of-the-box #26332

SandersAaronD opened this issue May 17, 2021 · 3 comments · Fixed by #27798
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation ready to take Help wanted. Guidance available. There is a high chance the change will be accepted

Comments

@SandersAaronD
Copy link

The gatsby example sandbox link doesn't run because sandbox defaults to node 10. It's simple to fork the base codesandbox in order to bump the version with a configuration file, and the readme for the gatsby example should be updated.

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Build fails while following the codesandbox link in examples/gatsby

Expected Behavior 🤔

Build succeeds when following the codesandbox link

Steps to Reproduce 🕹

Steps:

  1. Base codesandbox link goes here: https://codesandbox.io/s/github/mui-org/material-ui/tree/HEAD/examples/gatsby
  2. If you follow it, you will get a node version error.

Context 🔦

https://codesandbox.io/s/github/mui-org/material-ui/tree/HEAD/examples/gatsby is my fork that changes nothing except bumping the version in a config file. I can't commit to maintaining an image to keep it up to date, so I haven't put in a PR to redirect the link there.

@SandersAaronD SandersAaronD added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label May 17, 2021
@eps1lon eps1lon added bug 🐛 Something doesn't work docs Improvements or additions to the documentation and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jun 30, 2021
@eps1lon eps1lon assigned eps1lon and unassigned eps1lon Jun 30, 2021
@eps1lon
Copy link
Member

eps1lon commented Jun 30, 2021

The gatsby examples (examples/gatsby, examples/gatsby-theme), nextjs (examples/nextjs, examples/nextjs-with-typescript) and other SSR examples (examples/ssr need to use node 12 via creating a sandbox.config.json with

{
  "container": {
    "node": "12"
  }
}

The file needs to be next to the corresponding package.json.

@eps1lon eps1lon added the OCD21 label Jun 30, 2021
@oliviertassinari oliviertassinari added the ready to take Help wanted. Guidance available. There is a high chance the change will be accepted label Jul 16, 2021
@qiweiii
Copy link
Contributor

qiweiii commented Aug 16, 2021

I would like to take this issue

@oliviertassinari
Copy link
Member

A bit related #27331 (comment)

qiweiii pushed a commit to qiweiii/material-ui that referenced this issue Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation ready to take Help wanted. Guidance available. There is a high chance the change will be accepted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants