Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[List] Add runtime deprecation warnings #26709

Closed
2 tasks done
oliviertassinari opened this issue Jun 12, 2021 · 3 comments · Fixed by #26743
Closed
2 tasks done

[List] Add runtime deprecation warnings #26709

oliviertassinari opened this issue Jun 12, 2021 · 3 comments · Fixed by #26743
Labels
component: list This is the name of the generic UI component, not the React module! deprecation New deprecation message
Milestone

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 12, 2021

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

No warnings logged when doing:

              <ListItem
                key={childId}
                button
                sx={{ ...item, ...(active && { color: '#4fc3f7' }) }}
              >
                <ListItemIcon sx={{ minWidth: 'auto', mr: 2 }}>{icon}</ListItemIcon>
                <ListItemText>{childId}</ListItemText>
              </ListItem>

Expected Behavior 🤔

A warning is logged

Context 🕹

#26446 (comment)

cc @siriwatknp

@oliviertassinari oliviertassinari added component: list This is the name of the generic UI component, not the React module! deprecation New deprecation message labels Jun 12, 2021
@siriwatknp
Copy link
Member

good point, will create a PR for this one.

@oliviertassinari
Copy link
Member Author

@oliviertassinari
Copy link
Member Author

We talked about this issue during the team meeting on Monday (this week). From what I understand, we won't add a runtime deprecation. Instead, we will update the API generation docs to extract the deprecation from the JSDoc, and render it accordingly on the API pages.

Capture d’écran 2021-06-15 à 18 15 14

We will add the runtime warnings later on, during v5.x lifecycle.

@oliviertassinari oliviertassinari added this to the v5.1 milestone Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: list This is the name of the generic UI component, not the React module! deprecation New deprecation message
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants