Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[List] Add button runtime deprecation warning #26743

Merged
merged 6 commits into from
Jul 1, 2021
Merged

[List] Add button runtime deprecation warning #26743

merged 6 commits into from
Jul 1, 2021

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jun 14, 2021 •
edited
Loading

close #26709

preview https://deploy-preview-26743--material-ui.netlify.app/api/list-item/

  • update buildApi.ts to append deprecated, deprecationInfo.
  • update APIPage to render deprecation.

Screen Shot 2564-06-28 at 11 20 22

@mui-pr-bot
Copy link

mui-pr-bot commented Jun 14, 2021 •
edited
Loading

No bundle size changes (experimental)

Generated by 🚫 dangerJS against fdd0632

@eps1lon
Copy link
Member

eps1lon commented Jun 14, 2021 •
edited
Loading

What should be the correct approach (@oliviertassinari suggest deprecatedProptype but I notice that it fail the test)?

That I would check as well. Though I think we haven't used it in a while so docs generation might require an update.

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 14, 2021 •
edited
Loading

On 1. What do you mean by it fails the tests?
On 2. We get it for free by using deprecatedProptype. It was implemented around v1-beta if I recall correctly.

@oliviertassinari oliviertassinari deleted the branch mui:next June 22, 2021 00:28
@oliviertassinari oliviertassinari changed the base branch from foo to next June 22, 2021 00:44
@siriwatknp siriwatknp marked this pull request as ready for review June 25, 2021 10:38
@github-actions github-actions bot mentioned this pull request Jun 25, 2021
Closed
@oliviertassinari oliviertassinari changed the title [List] add button runtime deprecation warning [List] Add button runtime deprecation warning Jun 25, 2021
@oliviertassinari oliviertassinari added deprecation New deprecation message docs Improvements or additions to the documentation labels Jun 25, 2021
@siriwatknp siriwatknp requested a review from mnajdova June 29, 2021 11:02
mnajdova
mnajdova approved these changes Jul 1, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@siriwatknp siriwatknp merged commit 272e1e2 into mui:next Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@eps1lon eps1lon Awaiting requested review from eps1lon

@oliviertassinari oliviertassinari Awaiting requested review from oliviertassinari

Assignees
No one assigned
Labels
deprecation New deprecation message docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[List] Add runtime deprecation warnings
5 participants
@siriwatknp @mui-pr-bot @eps1lon @oliviertassinari @mnajdova