Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dialog] onBackdropClick deprecated in v4 but not v5 #31282

Closed
2 tasks done
mattmikolay opened this issue Mar 2, 2022 · 1 comment · Fixed by #32297
Closed
2 tasks done

[Dialog] onBackdropClick deprecated in v4 but not v5 #31282

mattmikolay opened this issue Mar 2, 2022 · 1 comment · Fixed by #32297
Assignees
@ZeeshanTamboli
Labels
component: dialog This is the name of the generic UI component, not the React module! v5.x migration

Comments

@mattmikolay
Copy link

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

In the MUI v4 API docs, the onBackdropClick prop of the Dialog component appears deprecated. I would expect the onBackdropClick prop to appear deprecated in MUI v5 as well, but as per the latest MUI v5 API docs, it is not.

Expected behavior 🤔

See above.

Steps to reproduce 🕹

Steps:

  1. Notice the onBackdropClick prop is marked with @deprecated on the v4.x branch.
  2. Notice the onBackdropClick prop is not marked with @deprecated on the master branch.

Context 🔦

No response

Your environment 🌎

No response
@mattmikolay mattmikolay added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Mar 2, 2022
@danilo-leal danilo-leal changed the title [Dialog] onBackdropClick deprecated in v4 but not v5 [Dialog] onBackdropClick deprecated in v4 but not v5 Mar 2, 2022
@danilo-leal danilo-leal added component: dialog This is the name of the generic UI component, not the React module! v5.x migration and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Mar 2, 2022
@ahmad-reza619
Copy link
Contributor

ahmad-reza619 commented Mar 3, 2022 •
edited
Loading

It looks like the team forgot to mark it as deprecated, can i open the PR for this?

@ZeeshanTamboli ZeeshanTamboli self-assigned this Apr 14, 2022
@ZeeshanTamboli ZeeshanTamboli mentioned this issue Apr 14, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZeeshanTamboli ZeeshanTamboli

Labels
component: dialog This is the name of the generic UI component, not the React module! v5.x migration
Projects
None yet
Milestone
No milestone
4 participants
@mattmikolay @ZeeshanTamboli @ahmad-reza619 @danilo-leal