Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Mark onBackdropClick prop as deprecated in Dialog, Modal and ModalUnstyled components #32297

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Apr 14, 2022

@ZeeshanTamboli ZeeshanTamboli added the docs Improvements or additions to the documentation label Apr 14, 2022
@mui-bot
Copy link

mui-bot commented Apr 14, 2022

No bundle size changes

Generated by 🚫 dangerJS against bf70a1b

@ZeeshanTamboli ZeeshanTamboli changed the title [Dialog] Mark onBackdropClick prop as deprecated [docs] Mark onBackdropClick prop as deprecated in Dialog, Modal and ModalUnstyled Apr 14, 2022
@ZeeshanTamboli ZeeshanTamboli changed the title [docs] Mark onBackdropClick prop as deprecated in Dialog, Modal and ModalUnstyled [docs] Mark onBackdropClick prop as deprecated in Dialog, Modal and ModalUnstyled components Apr 15, 2022
@ZeeshanTamboli ZeeshanTamboli requested a review from a team April 15, 2022 04:47
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, we probably should have even removed it. Fair enough, thanks for taking care of it.

@ZeeshanTamboli ZeeshanTamboli merged commit c758b6c into mui:master Apr 15, 2022
@ZeeshanTamboli ZeeshanTamboli deleted the issue/31282-mark-onBackdropClick-as-deprecated branch April 15, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dialog] onBackdropClick deprecated in v4 but not v5
3 participants