Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import PropTypes from prop-types instead of react #6662

Closed
DanielRamosAcosta opened this issue Apr 21, 2017 · 5 comments
Closed

Import PropTypes from prop-types instead of react #6662

DanielRamosAcosta opened this issue Apr 21, 2017 · 5 comments
Labels
core Infrastructure work going on behind the scenes v1.x

Comments

@DanielRamosAcosta
Copy link

DanielRamosAcosta commented Apr 21, 2017 •
edited
Loading

Import PropTypes from prop-types instead of react

I've been seaching in the Issues/PR and I didn't found any referencing this...

In React 15.5 importing the PropTypes from react package is starting to be depcreated as stated here, instead we should import it from prop-types package

Are there any plans of updating this in next version?

Versions

  • Material-UI: v1.0.0-alpha.11
  • React: 15.5.4
  • Browser: Chromium 57.0.2987.98 Built on Ubuntu , running on Ubuntu 17.04 (64-bit)
@DanielRamosAcosta DanielRamosAcosta changed the title Import Proptypes from prop-types instead of react Import PropTypes from prop-types instead of react Apr 21, 2017
@slavab89
Copy link
Contributor

I dont think its released yet but the code is already in next branch #6543

@DanielRamosAcosta
Copy link
Author

Ohh I see... I'll wait for the next release, thanks @slavab89 !

@mbrookes
Copy link
Member

It's already released: https://github.com/callemall/material-ui/releases/tag/v1.0.0-alpha.11

@DanielRamosAcosta
Copy link
Author

DanielRamosAcosta commented Apr 21, 2017 •
edited
Loading

I just looked a bit deeper and it seems these warnings are coming from react-transition-group@1.1.1, wich is used by the Ripple.

@DanielRamosAcosta
Copy link
Author

In commit ddb0be1 there was an upgrade of react-transition-group to v1.1.2, wich should fix these warnings.

@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 21, 2022
@zannager zannager added v1.x core Infrastructure work going on behind the scenes and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes v1.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mbrookes @oliviertassinari @slavab89 @DanielRamosAcosta @zannager