[react] Upgrade to [email protected] #6543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muibot
added
PR: needs revision
alitaheri
reviewed
Apr 8, 2017
| @@ -1,4 +1,5 @@ | |||
| import React from 'react'; | |||
| import PropTypes from 'prop-types'; | |||
There was a problem hiding this comment.
These files don't need prop-types
There was a problem hiding this comment.
Indeed, I'm on it :).
alitaheri
reviewed
Apr 8, 2017
package.json
Outdated
| @@ -46,6 +46,7 @@ | |||
| "publish": "npm run build && cd build && npm publish --tag next" | |||
| }, | |||
| "peerDependencies": { | |||
| "prop-types": "^15.0.0", | |||
There was a problem hiding this comment.
prop-types won't conflict. Adding it to peer dependencies will further complicate installs. Many won't use prop-types. Like some typescript users (me included 😁). Just add it to normal dependencies. fewer missing peer dependency warns and fewer breakage to take care of.
|
❤️ 🎉 ❤️ 🎉 ❤️ 🎉 ❤️ 🎉 ❤️ 🎉 ❤️ 🎉 ❤️ 🎉 ❤️ 🎉 ❤️ 🎉 ❤️ 🎉 ❤️ 🎉 ❤️ 🎉 ❤️ 🎉 |
alitaheri
reviewed
Apr 8, 2017
src/test-utils/createMount.js
Outdated
| @@ -3,7 +3,8 @@ | |||
| import { create } from 'jss'; | |||
| import jssPreset from 'jss-preset-default'; | |||
| import { createStyleManager } from 'jss-theme-reactor'; | |||
| import { PropTypes } from 'react'; | |||
| import 'react'; | |||
alitaheri
reviewed
Apr 8, 2017
src/utils/customPropTypes.js
Outdated
| @@ -2,7 +2,8 @@ | |||
| /* eslint-disable import/no-mutable-exports*/ | |||
| /* eslint-disable flowtype/require-valid-file-annotation */ | |||
|
|
|||
| import { PropTypes } from 'react'; | |||
| import 'react'; | |||
oliviertassinari
added
PR: Review Accepted
and removed
PR: Needs Review
PR: needs revision
|
I'm merging early. We have to start somewhere and other PR will most likely have to rebase. |
muibot
added
the
PR: needs revision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limitations:
Related to #6542