Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slider] IE: sliders don't work #708

Closed
luisrudge opened this issue May 28, 2015 · 13 comments
Closed

[Slider] IE: sliders don't work #708

luisrudge opened this issue May 28, 2015 · 13 comments
Labels
component: slider This is the name of the generic UI component, not the React module!

Comments

@luisrudge
Copy link
Contributor

sliders-dont-work

@luisrudge
Copy link
Contributor Author

Ops, sorry. Forgot to add my browser info:

image

@bruce55
Copy link

bruce55 commented Jun 2, 2015

Not able to drag it on Chrome 44.0.2403.9 either. It's only clickable here.

@luisrudge
Copy link
Contributor Author

Works for me on Version 43.0.2357.81 m

@hai-cea hai-cea changed the title IE: sliders don't work [Slider] IE: sliders don't work Jun 19, 2015
@tyleo
Copy link

tyleo commented Jun 21, 2015

This is also broken for me. However, I can control the slider in Chrome via a touchscreen even when my mouse fails to work.

@lionkeng
Copy link
Contributor

are there any updates on this? Would love to see it working on IE.

@lionkeng
Copy link
Contributor

material-ui depends on react-draggable2, which in turn is based on react-draggable. In that repo, there was an issue filed concerning IE11 problems, see
react-grid-layout/react-draggable#51
which has been fixed here:
react-grid-layout/react-draggable@932efd6
I can't tell if this fix has been pulled into react-draggable2.

@RickFrom1987
Copy link

Would be nice to get the updated React-draggable, as the sliders don't work in IE.

@brokenalarms
Copy link

This happens to me with all browsers (Chrome, IE11, Edge, Firefox), in the docs and in my own projects. You can click anywhere on the slider and it will move, but as soon as you start to drag it the slider breaks, and you cannot drag or click that particular slider any more until you refresh.

The only update is that every new time you try to drag the (now broken) slider again, it keeps applying the class 'react-draggable' over and over to the body.

I have tried updating react-draggable with the slider component, but as per package requirements this is not fully compatible with current material-ui - you then gain the ability to drag up but not down, and the actual range handle is invisible.

My temp solution is just deleting
this.setState({ dragging: true, active: true });

in the onDragStart event in lib/slider.js. Then at least clicking on the handle itself does not prevent the slider from being clicked on directly elsewhere without the component needing to be refreshed again.

@igorbt
Copy link
Contributor

igorbt commented Oct 15, 2015

@luisrudge bug was fixed in PR #1825 and merged, please retest and close.

@luisrudge
Copy link
Contributor Author

Is the main website (http://material-ui.com/#/components/sliders) up to date? It still doesn't work when I test there.

@igorbt
Copy link
Contributor

igorbt commented Oct 17, 2015

Not until next release.

@shaurya947
Copy link
Contributor

@luisrudge can you double check? Closing this for now.

@luisrudge
Copy link
Contributor Author

It's working, thanks!

@oliviertassinari oliviertassinari added the component: slider This is the name of the generic UI component, not the React module! label Aug 22, 2020
mnajdova pushed a commit to mnajdova/material-ui that referenced this issue Nov 10, 2020
Fix initialFocusedDate update on prop change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: slider This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

10 participants