Minor documentation bug on AutoComplete component page

[jcheroske]

Problem description

Documentation for AutoComplete props is incorrect. The following passage:

Other properties (not documented) are applied to the root element.

Should read:

Other properties (not documented) are applied to the TextField element.

[oliviertassinari]

I would rather say that it's an issue with the API of the AutoComplete. We can't do much without introducing a breaking change.

[jcheroske]

I don't understand your comment. The docs specifically state that extra props will be added to the root element. This is incorrect. The extra props get added to the text field, according to the code.

…

On Thu, Jun 29, 2017 at 11:38 PM Olivier Tassinari ***@***.***> wrote: I would rather say that it's an issue with the API of the AutoComplete. We can't do much without introducing a breaking change. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7296 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADgUytEQ-kx0MfoNrukhJQwNjYp_QOgAks5sJJfrgaJpZM4OKLrD> .

[oliviertassinari]

@jcheroske You are right. My point is that the comment should be enforce accros the component for simplicity. Making the code matchs the comment would introduce a breaking change. Given that the documentation is automatically generated. I would rather wait on the migration of the component to the v1-alpha branch. I hope that's more clear putted this way.

[jcheroske]

Just to be clear, here's what I'm talking about:

<div style={prepareStyles(Object.assign(styles.root, style))} > // <- This is the root & root style
        <TextField
          ref="searchTextField"
          autoComplete="off"
          onBlur={this.handleBlur}
          onFocus={this.handleFocus}
          onKeyDown={this.handleKeyDown}
          floatingLabelText={floatingLabelText}
          hintText={hintText}
          fullWidth={fullWidth}
          multiLine={false}
          errorStyle={errorStyle}
          style={textFieldStyle} <-------------------------- The style is not the root style!
          {...other} // <----------------------------------- The extra props are going here
          // value and onChange are idiomatic properties often leaked.
          // We prevent their overrides in order to reduce potential bugs.
          value={searchText}
          onChange={this.handleChange}
        />
        <Popover
          style={Object.assign({}, styles.popover, popoverStyle)}
          canAutoPosition={false}
          anchorOrigin={anchorOrigin}
          targetOrigin={targetOrigin}
          open={open}
          anchorEl={anchorEl}
          useLayerForClickAway={false}
          onRequestClose={this.handleRequestClose}
          animated={animated}
          animation={animation}
          {...popoverOther}
        >
          {menu}
        </Popover>
      </div>

The root is getting the root style, but not the props, even though the docs specifically say that the props go to the root. This is simply incorrect.

[oliviertassinari]

Duplicate of #6292