-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript Typings - WithWidthEnhancement width should be a string or enum #7826
Labels
Comments
Sounds correct, feel free to fix the typescript typings. |
I just saw there's a |
@vyrotek yup, exactly :) |
sebald
pushed a commit
that referenced
this issue
Aug 24, 2017
3 tasks
sebald
added a commit
that referenced
this issue
Aug 24, 2017
…nButton (#7897) * [typescript] Correct withWidth * [typescript] Rename WithWidthEnhancement. * [typescript] Improve typings for `withStyle` - add `theme` - enhanced components has "styled props" * [typescript] Correct BottomNavigationButton typings value -> any Closes #7826 Closes #7830 Closes #7889
Taldrain
pushed a commit
to Taldrain/material-ui
that referenced
this issue
Aug 24, 2017
…nButton (mui#7897) * [typescript] Correct withWidth * [typescript] Rename WithWidthEnhancement. * [typescript] Improve typings for `withStyle` - add `theme` - enhanced components has "styled props" * [typescript] Correct BottomNavigationButton typings value -> any Closes mui#7826 Closes mui#7830 Closes mui#7889
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem description
@sebald I believe width is supposed to be a string or enum and not a number;
The withWidth.js implementation seems to provide the following possible values.
xs | xs | sm | md | lg | xl
The text was updated successfully, but these errors were encountered: