Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeScript] Orientation in StepButton should be optional #9782

Closed
1 task done
hapood opened this issue Jan 8, 2018 · 1 comment
Closed
1 task done

[TypeScript] Orientation in StepButton should be optional #9782

hapood opened this issue Jan 8, 2018 · 1 comment
Labels
component: stepper This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. typescript

Comments

@hapood
Copy link
Contributor

hapood commented Jan 8, 2018 •
edited
Loading

  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Orientation in StepButton's props should be optional as document described.

Current Behavior

Orientation is a required prop, cause type missmatch.

Steps to Reproduce (for bugs)

<StepButton />

ERROR in /xxx/xx.tsx
[tsl] ERROR in /xxx/xx.tsx(240,29)
TS2322: Type '{ children: string[]; }' is not assignable to type 'IntrinsicAttributes & StepButtonProps & { children?: ReactNode; }'.
Type '{ children: string[]; }' is not assignable to type 'StepButtonProps'.
Property 'orientation' is missing in type '{ children: string[]; }'.

Context

Your Environment

Tech Version
Material-UI 1.0.0-beta.27
TypeScript 2.6.2
@oliviertassinari oliviertassinari added the component: stepper This is the name of the generic UI component, not the React module! label Jan 8, 2018
@pelotom pelotom added typescript good first issue Great for first contributions. Enable to learn the contribution process. labels Jan 8, 2018
@pelotom
Copy link
Member

pelotom commented Jan 8, 2018

Good catch, would you like to submit a PR to fix it?

hapood pushed a commit to hapood/material-ui that referenced this issue Jan 9, 2018
[StepButton] Fix typescript (mui#9782)
2862630
@hapood hapood mentioned this issue Jan 9, 2018
Merged
oliviertassinari pushed a commit to hapood/material-ui that referenced this issue Jan 9, 2018
@oliviertassinari
[StepButton] Fix typescript (mui#9782)
00371d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: stepper This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. typescript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pelotom @hapood @oliviertassinari