Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix dark theme display #11194

Merged
merged 1 commit into from
May 1, 2018
Merged

[docs] Fix dark theme display #11194

merged 1 commit into from
May 1, 2018

Conversation

oliviertassinari
Copy link
Member

Was planning to adopt the library for an internal site, using the dark theme. I was demonstrating to my boss and team, and they were a bit put off that some of the component demos didn't work in dark theme.

It should address @yzorg's concern. Thanks for proposing a fix. It took the liberty to try a different approach: only using the grid in the light display mode.

Closes #11190

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work docs Improvements or additions to the documentation labels May 1, 2018
@oliviertassinari oliviertassinari merged commit 7fca806 into mui:v1-beta May 1, 2018
@oliviertassinari oliviertassinari deleted the docs-dark-palette branch May 1, 2018 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oliviertassinari