Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eslint] enforce rule no-var #1135

Merged
merged 1 commit into from
Jul 12, 2015
Merged

[eslint] enforce rule no-var #1135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"no-shadow": 0,
"no-shadow-restricted-names": 0,
"no-extend-native": 0,
"no-var": 2,
"new-cap": 0,
"quotes": 0,
"semi-spacing": 0,
Expand Down
4 changes: 2 additions & 2 deletions src/menu/menu.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ let SubheaderMenuItem = require('./subheader-menu-item');
/***********************
* Nested Menu Component
***********************/
var NestedMenuItem = React.createClass({
let NestedMenuItem = React.createClass({

mixins: [ClickAwayable, StylePropable],

Expand Down Expand Up @@ -194,7 +194,7 @@ var NestedMenuItem = React.createClass({
/****************
* Menu Component
****************/
var Menu = React.createClass({
let Menu = React.createClass({

mixins: [StylePropable],

Expand Down
4 changes: 2 additions & 2 deletions src/utils/dom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ module.exports = {
},

getStyleAttributeAsNumber: function(el, attr) {
var attrStyle = el.style[attr];
var attrNum = 0;
let attrStyle = el.style[attr];
let attrNum = 0;
if (attrStyle && attrStyle.length) {
attrNum = parseInt(attrStyle);
}
Expand Down