[StepLabel] Allow StepIcon customization #11446
Merged
+19
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,6 +15,7 @@ export interface StepLabelProps | |||
| last?: boolean; | |||
| optional?: React.ReactNode; | |||
| orientation?: Orientation; | |||
| stepIconProps?: object; | |||
There was a problem hiding this comment.
I believe first letter should be upperCase
There was a problem hiding this comment.
Ah yes, you're right...I followed the convention on imgProps but img is not a React component hence the lower camel case.
I'll update my PR tomorrow.
oliviertassinari
changed the title
oliviertassinari
added
new feature
oliviertassinari
approved these changes
May 19, 2018
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First pull-request ever, please send constructive criticism ;)
This follows #11329 and option 2 of what was suggested:
Closes #11329