[core] Small changes investigating issues #12812
Conversation
oliviertassinari
force-pushed
the
misc-v2
branch
2 times, most recently
from
9a8fab7 to
a4c66f5
Compare
oliviertassinari
force-pushed
the
misc-v2
branch
from
a4c66f5 to
afbd74c
Compare
| this.componentWillUpdate = componentWillUpdate; | ||
| } | ||
| this.componentWillReceiveProps = componentWillReceiveProps; | ||
| this.componentWillReceiveProps.__suppressDeprecationWarning = true; |
| @@ -42,7 +42,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@babel/runtime": "7.0.0", | |||
| "recompose": "^0.29.0" | |||
| "recompose": "0.28.0 - 0.30.0" | |||
There was a problem hiding this comment.
@oliviertassinari Why was this necessary?
There was a problem hiding this comment.
It reduces the dependency duplication in people bundles. We can change it if it's an issue.
There was a problem hiding this comment.
@oliviertassinari Curious. I understand that it reduces duplication if we reduce the lower bound. But adding an upper bound should potentially increase it if users pin their own version to ^0.31, no?
There was a problem hiding this comment.
There is no v0.31.x version yet published on npm. If they do, we will have to evaluate the scope of the breaking changes before allowing it.
To be noted that recompose is deprecated. We can remove it in v4. Replacing recompose.pure by React.memo.
There was a problem hiding this comment.
Right. It's our only 0.x dependency. Still used in our docs though which makes me wonder why eslint is not reporting that we're using implicit dependencies.
No description provided.