Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement persistent text label without tooltip #12870

Closed
wants to merge 32 commits into from

Conversation

hashwin
Copy link
Contributor

@hashwin hashwin commented Sep 14, 2018

Followup from the conversation in #12856

Since the tooltip appearing and disappearing based on mouse movements is not required at all for this case, use of the tooltip can be avoided.

@oliviertassinari

@mbrookes

This comment has been minimized.

@hashwin

This comment has been minimized.

@oliviertassinari oliviertassinari added the package: lab Specific to @mui/lab label Sep 14, 2018
@mbrookes

This comment has been minimized.

@mbrookes

This comment has been minimized.

@hashwin

This comment has been minimized.

@hashwin

This comment has been minimized.

@oliviertassinari oliviertassinari force-pushed the master branch 2 times, most recently from 5db2370 to a4b65b7 Compare September 21, 2018 21:17
@mbrookes

This comment has been minimized.

@mbrookes mbrookes added the component: speed dial This is the name of the generic UI component, not the React module! label Sep 22, 2018
@hashwin

This comment has been minimized.

@hashwin

This comment has been minimized.

@mbrookes
Copy link
Member

mbrookes commented Sep 24, 2018

Okay, thanks @hashwin. In that case lets look to unify the styling, if not in this PR then a separate one.

@hashwin
Copy link
Contributor Author

hashwin commented Sep 24, 2018

@mbrookes Seems like the behavior specified by material design is not to use tooltips when hovering over, rather use extended FABs as specified here: https://material.io/design/components/buttons-floating-action-button.html#extended-fab

But that seems like it's independent of this feature, so I would leave that for a different PR.

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 27, 2018

I need to understand the issue first. What do you mean "behind"?

@eps1lon Let's say you are using a Windows surface (large screen) and a media query based logic to change the tooltip style, you might miss the information displayed when using a long touch to display the tooltip.

capture d ecran 2018-09-27 a 14 28 39

@eps1lon
Copy link
Member

eps1lon commented Sep 28, 2018

I need to understand the issue first. What do you mean "behind"?

@eps1lon Let's say you are using a Window surface (large screen) and a media query based logic to change the tooltip style, you might miss the information displayed when using a long touch to display the tooltip.

@oliviertassinari Can you link me some sites that have the same behavior? I have pretty big hands/fingers and I can still see that something popped up after a touch. How do you determine where the tootip would not be hidden behind the users finger? If I reach from the right and the placement is below nothing has to change. If I reach from the right and the placement is right I might not see it (as you said).

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 29, 2018

Can you link me some sites that have the same behavior?

@eps1lon Not I'm aware off. It's really about an interpretation of the specification, in a gray area. My point is that it should be touch/mouse based, it's better than a screen size based logic. It's what I believe provide a better UX.

@hashwin
Copy link
Contributor Author

hashwin commented Oct 1, 2018

FWIW I have had this branch running in my production app, and my users have reported that all the issues (hybrid device clicks, glitchy tooltip size, positioning and click behavior) have all been resolved.

@mbrookes
Copy link
Member

mbrookes commented Oct 9, 2018

Maybe the answer to the problem is really simple. Why do we override the CSS to always looks like

I think perhaps you meant "why don't we"? In that case, I agree - it solves the problem (even if those big-ass tooltips are a bit ugly).

@hashwin
Copy link
Contributor Author

hashwin commented Dec 24, 2018

@oliviertassinari @mbrookes @eps1lon Apologies, I haven't followed up on this, just wanted to check, was there any consensus on this? As I mentioned I have been using this branch AS IS on my production app and have had absolutely no problems.

@mbrookes
Copy link
Member

At this stage, given no further feedback, I'd suggest that merging this is better than the alternative.

Last call for comments @mui-org/core-contributors; otherwise, @hashwin if you could fix up the couple of code concerns that @eps1lon raised, and resolve the merge conflicts...

oliviertassinari and others added 4 commits February 2, 2019 22:36
* New translations css-in-js.md (Chinese Simplified)

* New translations text-fields.md (German)

* New translations showcase.md (German)

* New translations tooltips.md (German)

* New translations tabs.md (German)

* New translations tables.md (German)

* New translations steppers.md (German)

* New translations snackbars.md (German)

* New translations selects.md (German)

* New translations selection-controls.md (German)

* New translations progress.md (German)

* New translations menus.md (German)

* New translations migration-v0x.md (German)

* New translations slider.md (German)

* New translations composition.md (German)

* New translations usage.md (German)

* New translations breadcrumbs.md (German)

* New translations basics.md (French)

* New translations basics.md (French)

* New translations versions.md (French)

* New translations popper.md (French)

* New translations popover.md (French)

* New translations spacing.md (French)

* New translations expansion-panels.md (German)

* New translations dividers.md (German)

* New translations cards.md (German)

* New translations buttons.md (German)

* New translations badges.md (German)

* New translations avatars.md (German)

* New translations autocomplete.md (German)

* New translations app-bar.md (German)

* New translations modal.md (French)

* New translations menus.md (Japanese)

* New translations snackbars.md (Japanese)

* New translations dividers.md (Japanese)

* New translations usage.md (Japanese)

* New translations installation.md (Japanese)

* New translations comparison.md (Japanese)

* New translations showcase.md (Japanese)

* New translations buttons.md (Japanese)

* New translations modal.md (German)

* New translations links.md (German)

* New translations css-baseline.md (German)

* New translations app-bar.md (Japanese)

* New translations flexbox.md (German)

* New translations breadcrumbs.md (Chinese Simplified)

* New translations slider.md (Chinese Simplified)

* New translations typescript.md (Chinese Simplified)

* New translations composition.md (Chinese Simplified)

* New translations usage.md (Chinese Simplified)

* New translations transitions.md (Chinese Simplified)

* New translations modal.md (Chinese Simplified)

* New translations links.md (Chinese Simplified)

* New translations use-media-query.md (Chinese Simplified)

* New translations basics.md (Chinese Simplified)

* New translations buttons.md (Chinese Simplified)

* New translations dividers.md (Chinese Simplified)

* New translations badges.md (Chinese Simplified)

* New translations app-bar.md (Chinese Simplified)

* New translations links.md (French)

* New translations paper.md (Chinese Simplified)

* New translations comparison.md (Chinese Simplified)

* New translations showcase.md (Chinese Simplified)

* New translations pickers.md (Chinese Simplified)

* New translations text-fields.md (Chinese Simplified)

* New translations snackbars.md (Chinese Simplified)

* New translations selects.md (Chinese Simplified)

* New translations flow.md (French)

* New translations composition.md (French)

* New translations api.md (French)

* New translations usage.md (French)

* New translations supported-platforms.md (French)

* New translations showcase.md (French)

* New translations minimizing-bundle-size.md (French)

* New translations typography.md (French)

* New translations basics.md (Chinese Simplified)

* New translations hidden.md (French)

* New translations grid.md (French)

* New translations right-to-left.md (French)

* New translations breadcrumbs.md (French)

* New translations slider.md (French)

* New translations about.md (French)

* New translations typescript.md (French)

* New translations server-rendering.md (French)

* New translations icons.md (French)

* New translations text-fields.md (French)

* New translations buttons.md (French)

* New translations steppers.md (French)

* New translations snackbars.md (French)

* New translations selects.md (French)

* New translations selection-controls.md (French)

* New translations progress.md (French)

* New translations pickers.md (French)

* New translations tables.md (French)

* New translations menus.md (French)

* New translations dividers.md (French)

* New translations dialogs.md (French)

* New translations lists.md (French)

* New translations chips.md (French)

* New translations basics.md (Russian)

* New translations api.md (Russian)

* New translations advanced.md (Russian)

* New translations popper.md (Russian)

* New translations popover.md (Russian)

* New translations modal.md (Russian)

* New translations links.md (Russian)

* New translations basics.md (Russian)

* New translations icons.md (Russian)

* New translations buttons.md (Spanish)

* New translations color.md (Russian)

* New translations bottom-navigation.md (Spanish)

* New translations badges.md (Spanish)

* New translations avatars.md (Spanish)

* New translations autocomplete.md (Spanish)

* New translations app-bar.md (Spanish)

* New translations display.md (Russian)

* New translations spacing.md (Russian)

* New translations use-media-query.md (Russian)

* New translations related-projects.md (Russian)

* New translations installation.md (Russian)

* New translations faq.md (Russian)

* New translations example-projects.md (Russian)

* New translations comparison.md (Russian)

* New translations showcase.md (Russian)

* New translations tooltips.md (Russian)

* New translations text-fields.md (Russian)

* New translations tabs.md (Russian)

* New translations tables.md (Russian)

* New translations steppers.md (Russian)

* New translations usage.md (Russian)

* New translations hidden.md (Russian)

* New translations about.md (Russian)

* New translations grid.md (Russian)

* New translations breakpoints.md (Russian)

* New translations breadcrumbs.md (Russian)

* New translations slider.md (Russian)

* New translations learn.md (Russian)

* New translations testing.md (Russian)

* New translations migration-v0x.md (Russian)

* New translations interoperability.md (Russian)

* New translations composition.md (Russian)

* New translations cards.md (Spanish)

* New translations dialogs.md (Spanish)

* New translations modal.md (Spanish)

* New translations links.md (Spanish)

* New translations icons.md (Spanish)

* New translations popover.md (Spanish)

* New translations breadcrumbs.md (Spanish)

* New translations slider.md (Spanish)

* New translations popper.md (Spanish)

* New translations selects.md (Russian)

* New translations dividers.md (Spanish)

* New translations selection-controls.md (Spanish)

* New translations tooltips.md (Spanish)

* New translations text-fields.md (Spanish)

* New translations tabs.md (Spanish)

* New translations tables.md (Spanish)

* New translations steppers.md (Spanish)

* New translations snackbars.md (Spanish)

* New translations selects.md (Spanish)

* New translations progress.md (Spanish)

* New translations community.md (Spanish)

* New translations pickers.md (Spanish)

* New translations menus.md (Spanish)

* New translations expansion-panels.md (Spanish)

* New translations related-projects.md (Spanish)

* New translations migration-v0x.md (Spanish)

* New translations composition.md (Spanish)

* New translations usage.md (Spanish)

* New translations showcase.md (Spanish)

* New translations snackbars.md (Russian)

* New translations flow.md (Japanese)

* New translations selection-controls.md (Russian)

* New translations app-bar.md (Portuguese, Brazilian)

* New translations dividers.md (Portuguese, Brazilian)

* New translations selects.md (Portuguese, Brazilian)

* New translations text-fields.md (Portuguese, Brazilian)

* New translations snackbars.md (Portuguese, Brazilian)

* New translations menus.md (Portuguese, Brazilian)

* New translations about.md (Japanese)

* New translations breadcrumbs.md (Japanese)

* New translations slider.md (Japanese)

* New translations composition.md (Japanese)

* New translations basics.md (Japanese)

* New translations basics.md (Japanese)

* New translations modal.md (Japanese)

* New translations icons.md (Japanese)

* New translations showcase.md (Portuguese, Brazilian)

* New translations progress.md (Russian)

* New translations css-in-js.md (Russian)

* New translations dividers.md (Russian)

* New translations pickers.md (Russian)

* New translations menus.md (Russian)

* New translations lists.md (Russian)

* New translations expansion-panels.md (Russian)

* New translations dialogs.md (Russian)

* New translations themes.md (Russian)

* New translations chips.md (Russian)

* New translations cards.md (Russian)

* New translations buttons.md (Russian)

* New translations bottom-navigation.md (Russian)

* New translations avatars.md (Russian)

* New translations autocomplete.md (Russian)

* New translations app-bar.md (Russian)

* New translations composition.md (Portuguese, Brazilian)

* New translations usage.md (Portuguese, Brazilian)

* New translations installation.md (Portuguese, Brazilian)

* New translations modal.md (Portuguese, Brazilian)

* New translations links.md (Portuguese, Brazilian)

* New translations css-baseline.md (Portuguese, Brazilian)

* New translations breadcrumbs.md (Portuguese, Brazilian)

* New translations slider.md (Portuguese, Brazilian)

* New translations grid.md (Russian)

* New translations hidden.md (Russian)
@mbrookes
Copy link
Member

mbrookes commented Feb 5, 2019

@hashwin Are you happy to wrap this up?

Mahdi Ghadamyari and others added 2 commits February 7, 2019 17:22
* Update overrides.md

fix typo

* Simplification

* Grammar Changes

* Matt review
* add pressing Enter key handling to open Select

* tests fixed

* uniform behavior
@hashwin
Copy link
Contributor Author

hashwin commented Feb 8, 2019

@mbrookes Sure I will try to clean this up this weekend

@hashwin
Copy link
Contributor Author

hashwin commented Feb 11, 2019

@mbrookes I updated the branch, getting a regression failure with a screenshot, not sure how to fix it.

@mbrookes mbrookes changed the base branch from master to next February 11, 2019 22:19
@mbrookes
Copy link
Member

mbrookes commented Feb 11, 2019

@hashwin I have changed the target branch to next, as master is now only for bug fixes, but I'm afraid that means you will have to rebase again, sorry. After that I can accept the visual regression.

@oliviertassinari
Copy link
Member

I'm closing, feel free to continue the effort :)

@oliviertassinari oliviertassinari removed the package: lab Specific to @mui/lab label Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: speed dial This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants