[core] Work toward preventing Googlebot regressions #13323
Conversation
oliviertassinari
force-pushed
the
googlebot-test
branch
from
70b54fa to
1d52381
Compare
oliviertassinari
force-pushed
the
googlebot-test
branch
from
1d52381 to
9b9be2d
Compare
| @@ -95,7 +95,7 @@ module.exports = function setKarmaConfig(config) { | |||
| os: 'OS X', | |||
| os_version: 'Sierra', | |||
| browser: 'Chrome', | |||
| browser_version: '49.0', | |||
| browser_version: '45.0', | |||
There was a problem hiding this comment.
Isn't the bot running chrome@41?
There was a problem hiding this comment.
Sinon.js doesn't support it. It's also why we don't run the tests in IE11. At least, I couldn't make it pass.
There was a problem hiding this comment.
As I interpret their readme it should support IE11. But chrome only at 69 which doesn't make much sense to me. I'm probably misunderstanding their saucelabs badge.
So we are basically not doing any tests at all in IE11?
There was a problem hiding this comment.
Chrome: CSS & JavaScript support starts at v49. JavaScript support starts at v41 (for googlebot).
IE : CSS & JavaScript support starts at v11.
What do you think of that?
There was a problem hiding this comment.
I wish we could make the tests pass in IE11.
| connect(state => ({ | ||
| uiTheme: state.theme, | ||
| })), | ||
| withStyles(styles), |
There was a problem hiding this comment.
Fix a dev issue in IE11 for computing the class names.
| @@ -258,7 +258,7 @@ describe('<SwipeableDrawer />', () => { | |||
| wrapper.setProps({ disableDiscovery: true }); | |||
|
|
|||
| fireBodyMouseEvent('touchstart', { touches: [params.openTouches[0]] }); | |||
| if (['left', 'right'].includes(params.anchor)) { | |||
| if (['left', 'right'].indexOf(params.anchor) !== -1) { | |||
There was a problem hiding this comment.
Make the tests pass in Chrome 45.
|
I suspect refactoring the tests to work with IE11 and Chrome 41 are going to be time-consuming. |
|
Alright, v45 is still closer to v41 than v49. Let's merge. |
oliviertassinari
changed the title
Following the introduction of Googlebot support in #13271, I'm running the e2e tests closer to Chrome v41 to prevent regressions.