Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix some issue with i18n #13342

Merged
merged 2 commits into from
Oct 25, 2018
Merged

[docs] Fix some issue with i18n #13342

merged 2 commits into from
Oct 25, 2018

Conversation

hhshii
Copy link

@hhshii hhshii commented Oct 22, 2018

image

Closes #13367

@mbrookes
Copy link
Member

Thanks for the contribution. We normally manage translations here, and I have found, and hopefully fixed, the errant 'code' translation.

However the wrapping in <p> tags is slightly concerning. That doesn't show up in CrowdIn, so your PR may be the only way to fix it. We have github sync disabled at the moment while waiting for a bug fix from CrowdIn, so I'm putting the PR on hold until that's fixed.

@mbrookes mbrookes added docs Improvements or additions to the documentation on hold There is a blocker, we need to wait labels Oct 22, 2018
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work and removed on hold There is a blocker, we need to wait labels Oct 25, 2018
@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 25, 2018

Some changes:

@oliviertassinari oliviertassinari changed the title [docs] fix Expansion Panels demo of zh doc [docs] Fix some issue with i18n Oct 25, 2018
@oliviertassinari oliviertassinari merged commit 027ed9a into mui:master Oct 25, 2018
@oliviertassinari
Copy link
Member

@GFwer Thank you for reporting these issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants