Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Button] Fix styles classes isolation #13352

Merged
merged 3 commits into from
Oct 23, 2018
Merged

[Button] Fix styles classes isolation #13352

merged 3 commits into from
Oct 23, 2018

Conversation

MECarmody
Copy link
Contributor

@MECarmody MECarmody commented Oct 22, 2018 •
edited
Loading

Currently, a class like textPrimary will erroneously apply to an outlined button. I have updated the Button styling to match what is described in the docs as shown below. This will properly allow us to override text button styles separately from outlined button styles.

screen shot 2018-10-22 at 5 00 41 pm

eps1lon
eps1lon requested changes Oct 23, 2018
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argos fail is correct because the logic for the legacy variant flat was changed.

@MECarmody
Copy link
Contributor Author

@eps1lon thanks for the explanation, makes sense. fixed!

@oliviertassinari oliviertassinari changed the title [Button] fix styles so text classes aren't applied to outlined buttons [Button] Fix styles classes isolation Oct 23, 2018
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: button This is the name of the generic UI component, not the React module! labels Oct 23, 2018
@oliviertassinari oliviertassinari merged commit e7cf64a into mui:master Oct 23, 2018
@oliviertassinari
Copy link
Member

💯 For the classes isolation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: button This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MECarmody @oliviertassinari @eps1lon