Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] Fix Next.js warning "no title in _document.js" #13415

Merged
merged 2 commits into from
Oct 28, 2018
Merged

[examples] Fix Next.js warning "no title in _document.js" #13415

merged 2 commits into from
Oct 28, 2018

Conversation

iamhosseindhv
Copy link
Contributor

This PR fixes two errors with Nextjs example:

1: No title tag in pages/_document.

2: Cannot read property X of undefined pageProps.
pageProps prop in pages/_app can be undefined at times. So I've added a piece of code from Nextjs docs

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Oct 28, 2018
@oliviertassinari oliviertassinari changed the title [Examples - Nextjs SSR] Fix error 'no title in pages/_document' [examples] Fix Next.js warning "no title in _document.js" Oct 28, 2018
@oliviertassinari oliviertassinari merged commit fbc3807 into mui:master Oct 28, 2018
@oliviertassinari
Copy link
Member

@iamhosseindhv 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamhosseindhv @oliviertassinari