[docs] Add Google Analytics events #13451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
oliviertassinari
changed the title
|
@goldins Thank you for taking the time to look into the issue. However, it was already taken care of two days ago :). Instead, I'm adding some usage metrics to our demos. We will be able to leverage the data in different ways. For instance, we should be able to sort the demos within a page by their order of importance. |
|
Thanks for the quick response. My mistake, I saw the recent reported issue and wanted to look into it. I will look more closely at other open PRs next time. |
|
@oliviertassinari I'm not sure about the GA events commit though, why is that now part of this PR? |
|
@goldins I believe that the time you took looking in the issue is valuable. Having your name in the contributors list is a small token of appreciation. |
oliviertassinari
pushed a commit
to oliviertassinari/material-ui
that referenced
this pull request
Nov 1, 2018
* added anchorReference prop to Menu * [docs] Add Google Analytics events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by #13449, the Menu location was incorrect.