[docs] Add material-ui-pickers in pickers page #13697
Conversation
| @@ -0,0 +1,42 @@ | |||
| import React, { PureComponent } from 'react'; | |||
There was a problem hiding this comment.
Nitpick: Named import doesn't add anything. It's equivalent to import React from 'react' and React.PureComponent. I say this only for consistency.
There was a problem hiding this comment.
Do we need a pure component?
|
Hi @dmtrKovalenko, please don't use the Material-UI logo on your docs site, as it's likely to cause confusion as to whether it's an official project. |
oliviertassinari
added
the
component: date picker
oliviertassinari
changed the title
|
@mbrookes Fixed all code review points 💪 |
|
@dmtrKovalenko Great! I just need you to change the logo on the docs site. |
oliviertassinari
force-pushed
the
feature/mui-pickers-demo
branch
2 times, most recently
from
4287a11 to
e2cff7f
Compare
|
@mbrookes I am not going to change the logo. The project is peer dependent on material-ui, and we have used the material-ui logo from the project start and there were no issues with it. |
ISTR we asked you to change it back in May, and you agreed. Regardless, I'm asking you again now.
As explained briefly above, having the official Material-UI logo used by another project could lead to confusion as to whether is an official project. Having your own identity for your project also ensures you get credit where credit is due for your work. It works both ways. |
|
|
|
@dmtrKovalenko Thanks! Nice logo BTW. |
oliviertassinari
force-pushed
the
feature/mui-pickers-demo
branch
from
e2cff7f to
c771ab4
Compare
|
@dmtrKovalenko Thank you! |
Closes #13659
This PR adds demo for material-ui-pickers on pickers page. Additionally adds functionality for transpilling peer dependent on
@material-ui/corepackages correctly aliased to localcorepackage