Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TableCell] Add align to the TypeScript definition #14046

Merged
merged 2 commits into from
Jan 1, 2019
Merged

[TableCell] Add align to the TypeScript definition #14046

merged 2 commits into from
Jan 1, 2019

Conversation

rfbotto
Copy link
Contributor

@rfbotto rfbotto commented Dec 31, 2018

Closes #14014

@oliviertassinari oliviertassinari force-pushed the tablecell-align-prop-type branch from 89764cf to f3f3bae Compare December 31, 2018 16:19
@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 31, 2018 •
edited
Loading

@rfbotto I'm proposing the following fix the TypeScript error (f3f3bae), you can find the alternative in (89764cf). Does it sounds ok you?

@oliviertassinari oliviertassinari changed the title [TableCell] Add align prop typing to typescript definition [TableCell] Add align prop typing to TypeScript definition Dec 31, 2018
@oliviertassinari oliviertassinari changed the title [TableCell] Add align prop typing to TypeScript definition [TableCell] Add align to the TypeScript definition Dec 31, 2018
@oliviertassinari oliviertassinari merged commit b1cb553 into mui:master Jan 1, 2019
@oliviertassinari
Copy link
Member

@rfbotto Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rfbotto @oliviertassinari