[Button] Fix vertical alignment of text #14051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshwooding
force-pushed
the
fix-button-text-alignment
branch
2 times, most recently
from
1412672 to
52f8836
Compare
joshwooding
force-pushed
the
fix-button-text-alignment
branch
from
52f8836 to
c155371
Compare
|
Another thing I noticed, compare the following: Different All the same |
oliviertassinari
added
bug 🐛
|
I'm proposing another solution. We get the multiline support for free. While it's not encouraged, it can sometimes happen with long translations. |
|
I always celebrate bug fixes that removes code 🍾 🍸! |
oliviertassinari
force-pushed
the
fix-button-text-alignment
branch
from
5e2fe42 to
8158e51
Compare
oliviertassinari
approved these changes
Jan 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14042
I'm not sure if this is the right way to fix this, but the specification doesn't mention anything about top and bottom padding, only that the button text should be vertically centered. I've kept the padding not to break the look of the multi-line button but the spec explicitly encourages you not to use them