[Link] Fix type declaration for props

[swsnr]

Derive from AnchorHTMLAttributes to add anchor specific properties like href to prop types of Link. Otherwise tsc fails to compile when using arguably important properties like href and target.

• I have followed (at least) the PR section of the contributing guide.

[havenchyk]

@lunaryorn @essuraj @oliviertassinari guys, seems after this PR an example from docs (<Link component='button' ...) doesn't pass type check in typescript.

Link component='button' is allowed as I see in sources

Here is a demo with in TS https://codesandbox.io/s/728zylw051

would you like to accept a PR with a fix?

[eps1lon]

@havenchyk This is likely fixed in 4.0.0-beta.2 since we run type-check our demos. Could you verify if you can reproduce this with the latest beta version? If so please open a separate issue.

[havenchyk]

@eps1lon it works like a charm with 4.0.0-beta.2, but shouldn't we have this fixed for the next minor version of 3.9?

[eps1lon]

@eps1lon it works like a charm with 4.0.0-beta.2, but shouldn't we have this fixed for the next minor version of 3.9?

Unfortunately there's no good solution that doesn't introduce a breaking change. You can search the pull request for "generic props" to get a better understanding of the issue.

[havenchyk]

@eps1lon I'm sorry for asking here, but I can't find a way to define a type of component prop :(

It's generic in Link.d.ts, I want to pass this component value from a wrapper component in TS, maybe you can help with the resulted type of a component prop?

[eps1lon]

@havenchyk Have you checked out https://next.material-ui.com/components/links/#third-party-routing-library (open code and switch to the TS version). If this doesn't work please open a separate issue and follow the issue template