[ToggleButton] Update styles for Material v2 #14278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrookes
added
breaking change
component: toggle button
This comment has been minimized.
This comment has been minimized.
|
This should not have been so difficult, but got there in the end! 😅 The buttons required semi-transparent borders, so that the borders take on the background color if customized. However since the borders need to overlap, they are additive, creating varying shades of border, according to the state of adjacent buttons. JSS nested and sibling selectors to the rescue! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
joshwooding
approved these changes
Feb 10, 2019
oliviertassinari
approved these changes
Feb 10, 2019
|
In the future, I think that it would be great to introduce a button group component. |
2 tasks
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have followed (at least) the PR section of the contributing guide.
No drop-shadow
Outside border
Square buttons
Vertical separator between buttons
Lighter colors