Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ExpansionPanel] Fix square support #14282

Merged
merged 9 commits into from
Jan 23, 2019
Merged

[ExpansionPanel] Fix square support #14282

merged 9 commits into from
Jan 23, 2019

Conversation

brandonvilla21
Copy link
Contributor

@brandonvilla21 brandonvilla21 commented Jan 23, 2019 •
edited by oliviertassinari
Loading

Closes #14233

@oliviertassinari oliviertassinari changed the title Add square prop to expansion panel #14233 [ExpansionPanel] Fix square support Jan 23, 2019
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: accordion This is the name of the generic UI component, not the React module! labels Jan 23, 2019
@oliviertassinari oliviertassinari merged commit eca48d5 into mui:master Jan 23, 2019
@oliviertassinari
Copy link
Member

@joshwooding Has raised a good point regarding the non standard API naming in the paper component. The expansion panel mirrors it for consistency.

@oliviertassinari
Copy link
Member

@brandonvilla21 It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

@brandonvilla21
Copy link
Contributor Author

Thank you @oliviertassinari! It was fun :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: accordion This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandonvilla21 @oliviertassinari