[docs] Translate the key wordings #14317
Conversation
oliviertassinari
commented
Jan 27, 2019
•
oliviertassinari
commented
- Wait for people to update their documentation website to spam notifications
- Setup a minimal key translation infrastructure, to iterate
| @@ -0,0 +1,66 @@ | |||
| const translations = { | |||
There was a problem hiding this comment.
It would be great to move that file in Crowdin cc @mbrookes
There was a problem hiding this comment.
@alexanmtz Kindly offered to submit a POC PR using react-intl to allow us to translate strings in code, as he has already integrated it with CrowdIn for his own project. It would be great to be able to translate the home page.
I'm not sure how it will work with this file in its current structure (multiple languages concurrently), but I'm sure we can work out something that does.
There was a problem hiding this comment.
For me, the biggest challenge is to handle the translations data. Once we have it, I doubt we need any libraries. I have always found react-intl over engineered. https://airbnb.io/polyglot.js/ should often be enough. But I think that we can live without.
There was a problem hiding this comment.
Well, I would propose the integration with https://github.com/yahoo/react-intl to translate the strings as I did before in my project and I could integrate with Crowdin successfully. There's some tricks but I think it's a good approach to I18n with React, and there's some tools built upon it like https://github.com/yahoo/babel-plugin-react-intl
But I agree that is a little bit engineered but that fits in many scenarios.
There was a problem hiding this comment.
@alexanmtz Thank you for proposing your help 🙏. As far as I have looked that the problem, we only deal with static string data. We don't need to format, numbers, dates or handle dynamic data.
