Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Reset Table page number #14354

Merged
merged 3 commits into from
Jan 31, 2019
Merged

Conversation

rafaelmarinids
Copy link
Contributor

No description provided.

@joshwooding
Copy link
Member

@rafaelmarinids What problem is this fixing?

@rafaelmarinids
Copy link
Contributor Author

@rafaelmarinids What problem is this fixing?

@joshwooding sorry about that, I forgot to describe it. There is a problem when you change between 5 and 10 rows per page and navigates through the Pagination component.

Page: https://material-ui.com/demos/tables/#custom-table-pagination-action

Steps to reproduce:

  1. Select "Rows per page" 5, navigate throughout pages;
  2. Select "Rows per page" 10, navigate throughout pages;
  3. Select "Rows per page" 5 again, navigate throughout pages, the second page has 10 itens instead 5.

@oliviertassinari oliviertassinari changed the title Fixed rowsPerPage change [docs] Reset Table page number Jan 30, 2019
@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation component: table This is the name of the generic UI component, not the React module! labels Jan 30, 2019
@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 30, 2019

@rafaelmarinids I can confirm the same behavior using the tables of the Google Search Console:

capture d ecran 2019-01-30 a 21 23 08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: table This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants