-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[InputBase] Provide input adornments with FormControlContext #14364
Conversation
Yeah... I was fairly certain this would break the variant inheriting 😅 |
ce78854
to
d939f2b
Compare
@oliviertassinari Do we still need to set the value to null in InputBase if we do it in the InputAdornment? |
Comment got lost during #13590: Code got added in #10229: Original change didn't include a test. To be safe we should add a test that would fail prior to #10229 and then see if this test would pass now without setting the value to |
I agree, we’ve asked @mtidei for help reproducing the error so we can add a test |
d939f2b
to
14a95b0
Compare
14a95b0
to
07bb742
Compare
Fixes #14360