Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[README] Fix the underscored space on hover, rearrange thanks #14388

Merged
merged 1 commit into from
Feb 2, 2019
Merged

[README] Fix the underscored space on hover, rearrange thanks #14388

merged 1 commit into from
Feb 2, 2019

Conversation

mbrookes
Copy link
Member

@mbrookes mbrookes commented Feb 2, 2019

At the moment when you hover over a sponsor logo, this is an underlined space.

I also moved the technology sponsor logos above the descriptions, and added a logo for Codecov.

<img width="96" src="https://avatars1.githubusercontent.com/u/24789812?s=192" alt="bitsrc" title="The fastest way to share code">
</a>
<a href="https://www.creative-tim.com/?utm_source=material-ui&utm_medium=docs&utm_campaign=homepage" rel="noopener" target="_blank" style="margin-right: 16px;"><img width="126" src="https://avatars1.githubusercontent.com/u/20172349?s=378" alt="creative-tim" title="Premium Themes"></a>
<a href="https://bitsrc.io" rel="noopener" target="_blank" style="margin-right: 16px;"><img width="96" src="https://avatars1.githubusercontent.com/u/24789812?s=192" alt="bitsrc" title="The fastest way to share code"></a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given we copy & paste the same code between different document parts, should we apply the same change to the other locations? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I wondered that too, but then figured given how seldom (relatively) we add new sponsors, deleting a couple of new-lines isn't a huge overhead. I also wondered if prettier would complain if it was changed in a .js file...

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation PR: good for merge labels Feb 2, 2019
@oliviertassinari oliviertassinari merged commit 11a14cd into mui:next Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants