[docs] Fix IE11 crash on demo pages #14466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
bug 🐛
eps1lon
commented
Feb 8, 2019
| @@ -74,19 +74,14 @@ function MarkdownDocs(props) { | |||
| const jsType = isHooks ? 'jsHooks' : 'js'; | |||
| const rawType = isHooks ? 'rawHooks' : 'raw'; | |||
|
|
|||
| const tsFilename = !isHooks | |||
| ? sourceFiles.find(sourceFileName => { | |||
There was a problem hiding this comment.
Array.prototype.find is not supported in IE 11 an caused the crash
oliviertassinari
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without context easily the most overengineered code I pushed to
masterin the last couple of years.I think the original code was slightly different and necessary with the old demo loader. The new demo loader simplified the behavior but I missed a good refactoring chance.