Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix showcase #14494

Merged
merged 2 commits into from
Feb 11, 2019
Merged

[docs] Fix showcase #14494

merged 2 commits into from
Feb 11, 2019

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Feb 11, 2019 •
edited
Loading

Closes #14488

  • Implement stable sort
  • Simplify the render logic
  • Remove Alphabetical sort (what's the use case? fewer options = less confusion)
  • Change default ranking: date, it's creating an incentive for the project creators to add their project, it's creating an incentive for us to only add the best projects.

@oliviertassinari oliviertassinari changed the title Docs fix showcase [docs] Fix showcase Feb 11, 2019
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work docs Improvements or additions to the documentation new feature New feature or request and removed bug 🐛 Something doesn't work labels Feb 11, 2019
mbrookes
mbrookes reviewed Feb 11, 2019
View reviewed changes
docs/src/pages/discover-more/showcase/Showcase.js
<MenuItem value="byStars">{t('stars')}</MenuItem>
<MenuItem value="byTitle">{t('alphabetical')}</MenuItem>
<MenuItem value="similarWebVisits">{t('traffic')}</MenuItem>
<MenuItem value="index">{t('newest')}</MenuItem>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the default, perhaps move this to the top.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

docs/src/pages/discover-more/showcase/appList.js
'Share your portfolio with the world and see how you stack up to the best',
link: 'https://gadr.io/',
index: 33,
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the issue with this one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's yet another crypto project. It's displayed at the top when ranked by "Newest".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we don't have any screenshot.

@oliviertassinari oliviertassinari merged commit 0001318 into mui:next Feb 11, 2019
@oliviertassinari oliviertassinari deleted the docs-fix-showcase branch February 11, 2019 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrookes mbrookes mbrookes left review comments

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliviertassinari @mbrookes