[typescript] Fix theme.spacing to accept up to 4 arguments #14539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
eps1lon
previously requested changes
Feb 15, 2019
oliviertassinari
added
typescript
PR: needs revision
oliviertassinari
removed
the
PR: needs revision
|
@toshi1127 I have taken a shot at the problem, I still need to work on my TypeScript skills :). |
|
@oliviertassinari |
eps1lon
approved these changes
Feb 15, 2019
| @@ -1,4 +1,19 @@ | |||
| export type Spacing = (value: number | string) => number | string; | |||
| /* tslint:disable:unified-signatures */ | |||
There was a problem hiding this comment.
For future reference: The reason for disabling this rule here is that tslint suggests using (value1: SpacingArgument, value2?: SpacingArgument). This would however accept spacing(1, undefined) which we do not want to accept.
|
@toshi1127 and @oliviertassinari Thank you for working on this 😃 |
eps1lon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14515