[TableSortLabel] Increase size and show on hover #14650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leMaik
added
design: material
Details of bundle changes.Comparing: 1ca7af1...f5cf175
|
|
Looks good. We don't need the "Sort" tooltip any more. (The spec says to use the tooltip to show the full text of truncated headings, but the screenshots show it being used for a more verbose description of the column content... 🤔 ) |
I like UIs that don't need tooltips to explain how they work. 🎉
Material Design specs in a nutshell… |
oliviertassinari
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the table sort label to be spec-compliant again. 🎉
As seen here, the icon size is 18px now (with 3px padding, simmilar to
<IconButton size="small" />(not merged yet):As seen here, the arrow is now visible (in a less opaque color) when hovering the label. This improves the visibility of the sorting feature and reduces surprises when clicking on it.