Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[InputBase] Add missing TypeScript class keys #14684

Merged
merged 3 commits into from
Feb 27, 2019

Conversation

dmtrKovalenko
Copy link
Member

This PR adds 2 typings of adornedStart | adornedEnd class keys. They are working for the overrides but missing in ts typings

@dmtrKovalenko dmtrKovalenko changed the title Add missing class keys for adoredStart & AdornedEnd [typescript] Add missing class keys for adoredStart & AdornedEnd Feb 27, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Feb 27, 2019

No bundle size changes comparing 4a48c2f...ff7f62c

Generated by 🚫 dangerJS against ff7f62c

@dmtrKovalenko dmtrKovalenko changed the title [typescript] Add missing class keys for adoredStart & AdornedEnd [typescript] Add missing class keys for adornedStart & adornedEnd Feb 27, 2019
@oliviertassinari oliviertassinari changed the title [typescript] Add missing class keys for adornedStart & adornedEnd [typescript] Add missing InputBase class keys Feb 27, 2019
@oliviertassinari oliviertassinari changed the title [typescript] Add missing InputBase class keys [InputBase] Add missing TypeScript class keys Feb 27, 2019
@oliviertassinari
Copy link
Member

@dmtrKovalenko If you could use a fork for creating the pull request, it would be perfect:

capture d ecran 2019-02-27 a 18 29 35

@oliviertassinari oliviertassinari deleted the typings/InputBaseAdornedClasses branch February 27, 2019 17:30
@dmtrKovalenko
Copy link
Member Author

Oh, yep. Will use fork for future

@oliviertassinari
Copy link
Member

@dmtrKovalenko Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants