-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Document the migration from v3 to v4 #14741
[docs] Document the migration from v3 to v4 #14741
Conversation
Details of bundle changes.Comparing: a574657...9c13760
|
Co-Authored-By: oliviertassinari <[email protected]>
Co-Authored-By: oliviertassinari <[email protected]>
Co-Authored-By: oliviertassinari <[email protected]>
Co-Authored-By: oliviertassinari <[email protected]>
Co-Authored-By: oliviertassinari <[email protected]>
Co-Authored-By: oliviertassinari <[email protected]>
Co-Authored-By: oliviertassinari <[email protected]>
Co-Authored-By: oliviertassinari <[email protected]>
Co-Authored-By: oliviertassinari <[email protected]>
- `maxWidthLg` | ||
- `maxWidthXl` | ||
|
||
Have a look at [overriding with classes](/customization/overrides/#overriding-with-classes) section |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a look at [overriding with classes](/customization/overrides/#overriding-with-classes) section | |
Have a look at the [overriding with classes](/customization/overrides/#overriding-with-classes) section |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe remove 'section' at the end so the sentence reads:
Have a look at overriding with classes and the implementation of the component for more detail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is automatically generated, can we handle it in a different pull request? cc @mbrookes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both work, so I guess shorter is better?
Co-Authored-By: oliviertassinari <[email protected]>
Co-Authored-By: oliviertassinari <[email protected]>
You mean an automatic redirect? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer prop
over property
in react related docs. Not sure if this is common.
@mbrookes might want to go over the text as a native speaker.
- body1 (default) => body2 (default) | ||
- Remove the opinionated `display: block` default typograpghy style. | ||
You can use the new `display?: 'initial' | 'inline' | 'block';` property. | ||
- Rename the `headlineMapping` property to better align with its purpose. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Rename the `headlineMapping` property to better align with its purpose. | |
- Rename the `headlineMapping` prop to `variantMapping` to better align with its purpose. |
property
-> prop
depends on whether we use this consistently. I prefer to use the term prop
since it's specific to react. In vanilla javascript a property
of a class/function would mean something different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
property
vs prop
needs to be handled at a global level. I believe we are using property everywhere but I don't mind changing it to better match the reactjs.org wordings. cc @mbrookes. (I'm leaving it as is, we can handle it in a different pull request)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have looked at reactjs.org in more detail. I believe they always use prop
/props
in the React element context. I'm embarrassed.
@eps1lon I'm sorry for the confusion, I was thinking of a banner to link between master and next. So people can easily move between the versions. |
This pull request has generated two interested leads for continuation:
|
Once the next version is advanced enough, we should be able to link (add a banner) from material-ui.com to next.material-ui.com.