[Dialog] Add a dividers boolean prop #14795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
breaking change
component: dialog
Details of bundle changes.Comparing: 099bc5e...2f4cdd9
|
oliviertassinari
changed the title
oliviertassinari
force-pushed
the
dialog-scrollable
branch
from
0c9f4e3 to
2f4cdd9
Compare
oliviertassinari
changed the title
eps1lon
reviewed
Mar 10, 2019
There was a problem hiding this comment.
@oliviertassinari Forgot to submit review. Only concerned with missing changelog entries.
| return ( | ||
| <Typography component="p" variant="subtitle1" color="textSecondary" ref={ref} {...props} /> | ||
| ); | ||
| return <Typography component="p" variant="body1" color="textSecondary" ref={ref} {...props} />; |
There was a problem hiding this comment.
breaking change, needs changelog attention.
| }, | ||
| /* Styles applied to the children. */ | ||
| /* Styles applied to the root element if `disableActionSpacing={false}`. */ |
There was a problem hiding this comment.
breaking change, needs changelog attention.
eps1lon
added a commit
to eps1lon/material-ui
that referenced
this pull request
Mar 10, 2019
oliviertassinari
pushed a commit
that referenced
this pull request
Mar 11, 2019
* [docs] Add missing breaking changes from #14795 * fals€ -> false * remove pull request * Update docs/src/pages/guides/migration-v3/migration-v3.md Co-Authored-By: eps1lon <[email protected]> * Update docs/src/pages/guides/migration-v3/migration-v3.md Co-Authored-By: eps1lon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3155
Closes #14735
Closes #14777
Breaking change
Change the Dialog spacings to better match the specification: https://material.io/design/components/dialogs.html.