[Popper] Use refs instead of findDOMNode #14829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
commented
Mar 10, 2019
| @@ -171,6 +172,7 @@ class Popper extends React.Component { | |||
| return ( | |||
| <Portal onRendered={this.handleOpen} disablePortal={disablePortal} container={container}> | |||
| <div | |||
| ref={this.tooltip} | |||
There was a problem hiding this comment.
I didn't think it would be that easy but it seems like findDOMNode(this) drills through portals. Confirmed this by setting a breakpoint in handleOpen and the attributes matched the props that were spread from <Popper {...spread} />.
Details of bundle changes.Comparing: a5b8011...8bfc5cb
|
oliviertassinari
approved these changes
Mar 10, 2019
|
It's not too far from Poppers ✌️. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes deprecation warning StrictMode.
Trivia: The original PR title started with
[Pooper]. I still think that's funny.