[Table] Fix demo parse rowsPerPage value as an integer #14848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
oliviertassinari
added
docs
The pagination example has a bug where the rowsPerPage field is set to a string when you click on the dropdown. This is because `handleChangeRowsPerPage` method uses `event.target.value` which is a string value. To replicate this bug. Set page size to `10` then back to `5` and then click the next page button and you'll see that page 2 doesn't show 5 elements instead it shows 10. The `rowsPerPage` value is not recognized and I traced it down to it being set as a string instead of an integer.
oliviertassinari
force-pushed
the
patch-1
branch
from
702b347 to
6164349
Compare
oliviertassinari
approved these changes
Mar 11, 2019
|
No bundle size changes comparing 081abcf...6164349 |
|
@SimplyAhmazing Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pagination example has a bug where the rowsPerPage field is set to a string when you click on the dropdown. This is because
handleChangeRowsPerPagemethod usesevent.target.valuewhich is a string value.To replicate this bug. Set page size to
10then back to5and then click the next page button and you'll see that page 2 doesn't show 5 elements instead it shows 10. TherowsPerPagevalue is not recognized and I traced it down to it being set as a string instead of an integer.Working example: https://codesandbox.io/s/52y11rp96p