Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add react-basket to related projects #14941

Merged
merged 3 commits into from
Mar 18, 2019
Merged

[docs] Add react-basket to related projects #14941

merged 3 commits into from
Mar 18, 2019

Conversation

mbrn
Copy link
Contributor

@mbrn mbrn commented Mar 18, 2019

Hi,

I added a new library to related projects. Thanks

@mui-pr-bot
Copy link

mui-pr-bot commented Mar 18, 2019

No bundle size changes comparing 10438a1...3115897

Generated by 🚫 dangerJS against 3115897

@oliviertassinari oliviertassinari changed the title Added react-basket to related projects [docs] Add react-basket to related projects Mar 18, 2019
Copy link
Member

@mbrookes mbrookes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit pick (and applied the same the the line above)...

@mbrookes
Copy link
Member

mbrookes commented Mar 18, 2019

Nice job, although I notice on the demo that the total doesn't update as you add products?

@mbrookes mbrookes added the docs Improvements or additions to the documentation label Mar 18, 2019
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will soon provide a third-party plugin search like https://www.gatsbyjs.org/plugins/.

@oliviertassinari
Copy link
Member

@mbrn Regarding your project, you should make react and material-ui as peer dependencies.

@mbrn
Copy link
Contributor Author

mbrn commented Mar 18, 2019

Nice job, although I notice on the demo that the total doesn't update as you ad products?

Sorry, I am still working on it :)

@mbrn
Copy link
Contributor Author

mbrn commented Mar 18, 2019

@mbrn Regarding your project, you should make react and material-ui as peer dependencies.

You are right. I will do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants