Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Grammar fix in FAQ #14974

Merged
merged 3 commits into from
Mar 21, 2019
Merged

[docs] Grammar fix in FAQ #14974

merged 3 commits into from
Mar 21, 2019

Conversation

rtalvarez
Copy link
Contributor

What?

Just fixing a minor grammar issue on the FAQ pages.

@mui-pr-bot
Copy link

mui-pr-bot commented Mar 20, 2019 •
edited
Loading

No bundle size changes comparing ee5acf3...a07a03e

Generated by 🚫 dangerJS against a07a03e

@mbrookes
Copy link
Member

@rtalvarez Thanks for this. I have suggested a further fix for the grammar. Also, please add a blank line above the block-quote.

No need to change the translations. Crowdin will take care of that. (Although it did highlight the block-quote problem, so thanks anyway!)

@rtalvarez
Copy link
Contributor Author

I see, yeah I wasn't sure if the translations needed to be changed but did so for good measure, thanks for the heads up

@mbrookes mbrookes added docs Improvements or additions to the documentation PR: good for merge labels Mar 20, 2019
@rtalvarez
Copy link
Contributor Author

Not sure why regressions are failing 😢 story of my life

@mbrookes
Copy link
Member

Nothing to do with your PR, that's for sure. Sorry for the hassle!

@rtalvarez
Copy link
Contributor Author

Haha I know; just embracing the failures 🐑

@oliviertassinari oliviertassinari merged commit a2a3771 into mui:next Mar 21, 2019
@oliviertassinari
Copy link
Member

@rtalvarez We still have some flakiness to solve with our continuous integration pipeline. Merged
It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

@rtalvarez rtalvarez deleted the grammar-fix branch March 21, 2019 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrookes mbrookes mbrookes left review comments

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rtalvarez @mui-pr-bot @mbrookes @oliviertassinari