Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Grow] Convert to function component #15134

Merged
merged 3 commits into from
Apr 3, 2019
Merged

[Grow] Convert to function component #15134

merged 3 commits into from
Apr 3, 2019

Conversation

joshwooding
Copy link
Member

@joshwooding joshwooding added new feature New feature or request component: transitions This is the name of the generic UI component, not the React module! labels Mar 31, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Mar 31, 2019 •
edited
Loading

@material-ui/core: parsed: -0.16% 😍, gzip: -0.18% 😍
@material-ui/lab: parsed: -0.38% 😍, gzip: +0.16%

Details of bundle changes.

Comparing: 49bb455...6dce343

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core -0.16% -0.18% 350,340 349,777 89,987 89,822
@material-ui/core/Paper 0.00% 0.00% 67,853 67,853 19,820 19,820
@material-ui/core/Paper.esm 0.00% 0.00% 60,184 60,184 18,563 18,563
@material-ui/core/Popper 0.00% 0.00% 30,463 30,463 10,530 10,530
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 17,364 17,364 5,726 5,726
@material-ui/core/useMediaQuery 0.00% 0.00% 2,469 2,469 1,041 1,041
@material-ui/lab -0.38% +0.16% 🔺 148,259 147,696 43,562 43,631
@material-ui/styles 0.00% 0.00% 53,105 53,105 15,433 15,433
@material-ui/system 0.00% 0.00% 17,136 17,136 4,525 4,525
Button 0.00% 0.00% 87,927 87,927 26,054 26,054
Modal 0.00% 0.00% 82,035 82,035 24,552 24,552
colorManipulator 0.00% 0.00% 3,232 3,232 1,299 1,299
docs.landing 0.00% 0.00% 49,899 49,899 10,803 10,803
docs.main -0.09% -0.06% 645,314 644,724 200,459 200,342
packages/material-ui/build/umd/material-ui.production.min.js -0.16% -0.11% 298,651 298,174 82,718 82,627

Generated by 🚫 dangerJS against 6dce343

@joshwooding joshwooding force-pushed the grow-function-component branch 3 times, most recently from dca6b89 to 0c98882 Compare March 31, 2019 22:12
@joshwooding joshwooding force-pushed the grow-function-component branch from 0c98882 to 1284e4f Compare April 1, 2019 21:06
@joshwooding joshwooding force-pushed the grow-function-component branch from 747263d to 6064c20 Compare April 1, 2019 22:55
@joshwooding joshwooding marked this pull request as ready for review April 2, 2019 06:12
@oliviertassinari oliviertassinari merged commit f28bc48 into mui:next Apr 3, 2019
@joshwooding joshwooding deleted the grow-function-component branch April 3, 2019 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon left review comments

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: transitions This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshwooding @mui-pr-bot @oliviertassinari @eps1lon