Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[styles] Fix types of ServerStyleSheets.collect #15156

Merged
merged 1 commit into from
Apr 2, 2019
Merged

[styles] Fix types of ServerStyleSheets.collect #15156

merged 1 commit into from
Apr 2, 2019

Conversation

evenchange4
Copy link
Contributor

@evenchange4 evenchange4 commented Apr 2, 2019 •
edited
Loading

@mui-pr-bot
Copy link

No bundle size changes comparing 240dc18...917c7a6

Generated by 🚫 dangerJS against 917c7a6

@eps1lon eps1lon added typescript package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. labels Apr 2, 2019
@eps1lon eps1lon merged commit cea61be into mui:next Apr 2, 2019
@eps1lon eps1lon changed the title [styles] fix types of ServerStyleSheets.collect [styles] Fix types of ServerStyleSheets.collect Apr 2, 2019
@eps1lon
Copy link
Member

eps1lon commented Apr 2, 2019

@evanstern Thank you for working on this. Would be nice if you could follow up with more specific types for the options object.

@evenchange4 evenchange4 deleted the patch-1 branch April 3, 2019 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@evenchange4 @mui-pr-bot @eps1lon @oliviertassinari