-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Document sharing makeStyles between components #15234
Conversation
@oliviertassinari please give it a look and see if it all make sense, thx! |
No bundle size changes comparing bd7f1e7...941434b |
I had in mind something less practical but more generic around how the relative specificity works. |
Co-Authored-By: johnraz <[email protected]>
I will read the source code to understand what exactly is going on and I’ll try to improve this. |
@oliviertassinari : would it be right to assimilate this doc about What I get from the doc above is that Sorry if that seems obvious but I'd better be safe than sorry here 😉 |
@johnraz I'm proposing an alternative wording, it's more generic. You shouldn't have to create a new makeStyle in each file. Imports should be working. Thanks for the JSS link, it was helpful. |
This is perfect! It actually answered the last doubts I had about how it works 👍🏻 Thanks for the welcoming exchange btw! |
@johnraz Great :). Could you accept the @joshwooding's suggestions you agree with? Thanks. |
Co-Authored-By: johnraz <[email protected]>
@oliviertassinari sure thing, I was on my phone before, needed the laptop to do it properly ;-) |
@johnraz Thank you for the care in the problem. |
Closes #15214