Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[InputBase] Fix placeholder bug in Edge #15267

Merged

Conversation

rodrigoea
Copy link
Contributor


Fixes #15183

This PR fixes a bug related to the Placeholder and Label. They are being overlapped when a Input is focused and then unfocused by clicking at the address bar.

This bug is only happening in Edge.

FYI @oliviertassinari :)

@rodrigoea rodrigoea changed the title [InputBase] Fixes placeholder bug in Edge [InputBase] Fix placeholder bug in Edge Apr 8, 2019
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! labels Apr 8, 2019
@oliviertassinari oliviertassinari changed the base branch from master to next April 9, 2019 10:20
@oliviertassinari oliviertassinari force-pushed the fix-text-fields-placeholder-edge branch from cebe700 to 5f3bca3 Compare April 9, 2019 10:20
@oliviertassinari
Copy link
Member

@rodrigolabs I have rebased the pull request on the next branch. We keep master for important bug fixes. This one is about polishing the details ✨.

@oliviertassinari oliviertassinari force-pushed the fix-text-fields-placeholder-edge branch from 5f3bca3 to b3bae4c Compare April 9, 2019 11:32
@mui-pr-bot
Copy link

Details of bundle changes.

Comparing: 5bbf156...b3bae4c

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core 0.00% +0.01% 🔺 347,555 347,568 89,884 89,893
@material-ui/core/Paper 0.00% 0.00% 68,404 68,404 20,053 20,053
@material-ui/core/Paper.esm 0.00% 0.00% 60,735 60,735 18,785 18,785
@material-ui/core/Popper 0.00% 0.00% 34,930 34,930 11,917 11,917
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 17,877 17,877 5,962 5,962
@material-ui/core/useMediaQuery 0.00% 0.00% 2,463 2,463 1,044 1,044
@material-ui/lab 0.00% 0.00% 148,119 148,119 43,913 43,913
@material-ui/styles 0.00% 0.00% 53,143 53,143 15,443 15,443
@material-ui/system 0.00% 0.00% 17,132 17,132 4,519 4,519
Button 0.00% 0.00% 88,669 88,669 26,423 26,423
Modal 0.00% 0.00% 82,688 82,688 24,802 24,802
colorManipulator 0.00% 0.00% 3,745 3,745 1,537 1,537
docs.landing 0.00% 0.00% 49,820 49,820 10,807 10,807
docs.main 0.00% +0.01% 🔺 644,617 644,630 200,866 200,877
packages/material-ui/build/umd/material-ui.production.min.js 0.00% +0.01% 🔺 296,244 296,257 82,800 82,811

Generated by 🚫 dangerJS against b3bae4c

@oliviertassinari oliviertassinari merged commit e14d6f1 into mui:next Apr 9, 2019
@oliviertassinari
Copy link
Member

@rodrigolabs It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

@rodrigoea
Copy link
Contributor Author

@oliviertassinari Thank you! It was a pleasure to contribute after a while just using Material-UI ❤️

@rodrigoea rodrigoea deleted the fix-text-fields-placeholder-edge branch August 9, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IE Edge - TextField placeholder doesn't disappear when field is not focused
3 participants